Skip to content

[0.87] Bootstrap Metro from InitializeCore until setup-env is graph-reachable#57553

Open
zeyap wants to merge 1 commit into
0.87-stablefrom
fix-initializecore-bootstrap-0.87-v2
Open

[0.87] Bootstrap Metro from InitializeCore until setup-env is graph-reachable#57553
zeyap wants to merge 1 commit into
0.87-stablefrom
fix-initializecore-bootstrap-0.87-v2

Conversation

@zeyap

@zeyap zeyap commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Supersedes #57551 (which was cut before #57498 and became conflicting). This version is rebased on the current 0.87-stable and keeps the #57498 specifier style (no reintroduced path import).

Summary

Fresh 0.87 projects redbox on launch — e.g.:

Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
Module has not been registered as callable.
Registered callable JavaScript modules (n = 1): AppRegistry.

(The named module varies — HMRClient.setup(), RCTDeviceEventEmitter.emit() — it's whichever callable module native calls first.) n = 1: AppRegistry is the tell: core initialization never runs.

Root cause (#57475)

Core init runs via Metro's serializer.getModulesRunBeforeMainModule. Metro (metro/src/lib/getAppendScripts.js) only emits the run-before __r() for a module already present in the bundle graph, and silently skips it otherwise:

const paths = [...options.runBeforeMainModule, entryPoint];
for (const path of paths) {
  if (modules.some((module) => module.path === path)) {  // only if already in the graph
    /* __r(moduleId) */
  }
}

#57475 switched the run-before target from Libraries/Core/InitializeCoresrc/setup-env.js.

  • InitializeCore.js is reachable (imported by Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js).
  • src/setup-env.js is imported by nothing → not in the graph → silently skipped → core init never runs.

The two modules are functionally identical (both call setUpDefaultReactNativeEnvironment().default()), so only reachability changed. Note #57498 was cosmetic (same resolved file), so it does not fix this.

Evidence (bundle tail)

Run-before target Bundle tail Boots?
setup-env (current) __r(0);
InitializeCore (this PR) __r(<InitializeCore>); __r(0);

Verified end-to-end via test-release-local -t RNTestProject -p iOS. Ruled out: Metro cache (cold --reset-cache identical), stale Metro, and #57484 (./src/* exports removal).

Scope — interim stopgap

Only the internal Metro bootstrap target reverts to InitializeCore. The public react-native/setup-env entry point and its deprecation of InitializeCore are unchanged.

The durable fix (make setup-env graph-reachable, or make Metro treat getModulesRunBeforeMainModule entries as graph roots) should land on main and supersede this. cc @huntie — this is your setup-env stack. main uses equivalent wiring, so it's likely affected too.

Changelog

[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.

Test Plan

  • yarn test-release-local -t RNTestProject -p iOS: app boots without the redbox.
  • Bundle tail contains __r(<InitializeCore>); __r(0); instead of just __r(0);.

…eachable

Summary:
Fresh 0.87 projects redbox on launch with:

  Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
  Module has not been registered as callable.
  Registered callable JavaScript modules (n = 1): AppRegistry.

Core initialization never runs. Metro's `getModulesRunBeforeMainModule`
(see metro/src/lib/getAppendScripts.js) only emits the run-before `__r()`
call for a module that is *already present in the bundle graph*, and
silently skips it otherwise.

to `src/setup-env.js`. `InitializeCore` is reachable in the graph (imported
by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`), but
`src/setup-env.js` is imported by nothing, so Metro skips it and core init
never runs. The two modules are functionally identical (both call
`setUpDefaultReactNativeEnvironment().default()`).

Evidence (bundle tail):
- setup-env target:     `__r(0);`            (broken)
- InitializeCore target: `__r(110); __r(0);`  (fixed)

This is an INTERIM stopgap to unblock the 0.87 RC. It only changes the
internal Metro bootstrap target back to `InitializeCore`; the public
`react-native/setup-env` entry point and its deprecation of InitializeCore
are unchanged. The proper fix (make `setup-env` graph-reachable, or make
Metro treat `getModulesRunBeforeMainModule` entries as graph roots) should
land on main and supersede this.

Changelog:
[General][Fixed] - Fix apps failing to boot ("RCTDeviceEventEmitter not
registered as callable") due to core init not running.

Test Plan:
- `yarn test-release-local -t RNTestProject -p iOS`: app boots without redbox.
- Bundle tail now contains `__r(<InitializeCore>); __r(0);` instead of just `__r(0);`.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2026
@github-actions

Copy link
Copy Markdown

Caution

Missing Changelog

Please add a Changelog to your PR description. See Changelog format

@zeyap zeyap closed this Jul 14, 2026
meta-codesync Bot pushed a commit that referenced this pull request Jul 15, 2026
#57557)

Summary:
Pull Request resolved: #57557

Fresh projects **redbox on launch** — e.g.:

```
Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
Module has not been registered as callable.
Registered callable JavaScript modules (n = 1): AppRegistry.
```

(The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**.

## Root cause (#57475)

Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise:

```js
const paths = [...options.runBeforeMainModule, entryPoint];
for (const path of paths) {
  if (modules.some((module) => module.path === path)) {  // only if already in the graph
    /* __r(moduleId) */
  }
}
```

**#57475 switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`.

- `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`).
- `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs.

The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. #57498 was cosmetic (same resolved file) and does not fix this.

### Evidence (bundle tail)

| Run-before target | Bundle tail | Boots? |
|---|---|---|
| `setup-env` (current) | `__r(0);` | ❌ |
| `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ |

Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and #57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green.

## Scope — interim stopgap

Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**.

The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner).

A cherry-pick of this is also up against `0.87-stable` (#57553).

## Changelog

[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.

Reviewed By: christophpurrer

Differential Revision: D112002434

fbshipit-source-id: ea3559ef74d31f2c0f9af78aa0a020f4b322e7e0
@zeyap zeyap reopened this Jul 15, 2026
react-native-bot pushed a commit that referenced this pull request Jul 15, 2026
#57557)

Summary:
Pull Request resolved: #57557

Fresh projects **redbox on launch** — e.g.:

```
Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
Module has not been registered as callable.
Registered callable JavaScript modules (n = 1): AppRegistry.
```

(The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**.

## Root cause (#57475)

Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise:

```js
const paths = [...options.runBeforeMainModule, entryPoint];
for (const path of paths) {
  if (modules.some((module) => module.path === path)) {  // only if already in the graph
    /* __r(moduleId) */
  }
}
```

**#57475 switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`.

- `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`).
- `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs.

The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. #57498 was cosmetic (same resolved file) and does not fix this.

### Evidence (bundle tail)

| Run-before target | Bundle tail | Boots? |
|---|---|---|
| `setup-env` (current) | `__r(0);` | ❌ |
| `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ |

Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and #57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green.

## Scope — interim stopgap

Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**.

The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner).

A cherry-pick of this is also up against `0.87-stable` (#57553).

## Changelog

[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.

Reviewed By: christophpurrer

Differential Revision: D112002434

fbshipit-source-id: ea3559ef74d31f2c0f9af78aa0a020f4b322e7e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant