Skip to content

Bootstrap Metro from InitializeCore until setup-env is graph-reachable (#57554)#57557

Closed
zeyap wants to merge 1 commit into
react:mainfrom
zeyap:export-D112002434
Closed

Bootstrap Metro from InitializeCore until setup-env is graph-reachable (#57554)#57557
zeyap wants to merge 1 commit into
react:mainfrom
zeyap:export-D112002434

Conversation

@zeyap

@zeyap zeyap commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary:
Fresh projects redbox on launch — e.g.:

Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
Module has not been registered as callable.
Registered callable JavaScript modules (n = 1): AppRegistry.

(The named module varies — HMRClient.setup(), RCTDeviceEventEmitter.emit() — it's whichever callable module native calls first.) n = 1: AppRegistry is the tell: core initialization never runs.

Root cause (#57475)

Core init runs via Metro's serializer.getModulesRunBeforeMainModule. Metro (metro/src/lib/getAppendScripts.js) only emits the run-before __r() for a module already present in the bundle graph, and silently skips it otherwise:

const paths = [...options.runBeforeMainModule, entryPoint];
for (const path of paths) {
  if (modules.some((module) => module.path === path)) {  // only if already in the graph
    /* __r(moduleId) */
  }
}

#57475 switched the run-before target from Libraries/Core/InitializeCoresrc/setup-env.js.

  • InitializeCore.js is reachable (imported by Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js).
  • src/setup-env.js is imported by nothing → not in the graph → silently skipped → core init never runs.

The two modules are functionally identical (both call setUpDefaultReactNativeEnvironment().default()), so only reachability changed. #57498 was cosmetic (same resolved file) and does not fix this.

Evidence (bundle tail)

Run-before target Bundle tail Boots?
setup-env (current) __r(0);
InitializeCore (this PR) __r(<InitializeCore>); __r(0);

Verified end-to-end via test-release-local -t RNTestProject -p iOS. Ruled out: Metro cache (cold --reset-cache identical), stale Metro, and #57484 (./src/* exports removal). Reproduces via the react-native-community/cli bundling path (OSS react-native start); internal Meta bundling is unaffected, which is why CI/internal stayed green.

Scope — interim stopgap

Only the internal Metro bootstrap target reverts to InitializeCore. The public react-native/setup-env entry point and its deprecation of InitializeCore are unchanged.

The durable fix is to make setup-env graph-reachable (or make Metro treat getModulesRunBeforeMainModule entries as graph roots) — which will then allow InitializeCore to be removed as intended. cc huntie (setup-env stack owner).

A cherry-pick of this is also up against 0.87-stable (#57553).

Changelog

[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.

Test Plan:

  • yarn test-release-local -t RNTestProject -p iOS: app boots without the redbox.
  • Bundle tail contains __r(<InitializeCore>); __r(0); instead of just __r(0);.

Reviewed By: christophpurrer

Differential Revision: D112002434

Pulled By: zeyap

react#57554)

Summary:
Fresh projects **redbox on launch** — e.g.:

```
Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
Module has not been registered as callable.
Registered callable JavaScript modules (n = 1): AppRegistry.
```

(The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**.

## Root cause (react#57475)

Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise:

```js
const paths = [...options.runBeforeMainModule, entryPoint];
for (const path of paths) {
  if (modules.some((module) => module.path === path)) {  // only if already in the graph
    /* __r(moduleId) */
  }
}
```

**react#57475 switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`.

- `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`).
- `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs.

The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. react#57498 was cosmetic (same resolved file) and does not fix this.

### Evidence (bundle tail)

| Run-before target | Bundle tail | Boots? |
|---|---|---|
| `setup-env` (current) | `__r(0);` | ❌ |
| `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ |

Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and react#57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green.

## Scope — interim stopgap

Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**.

The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner).

A cherry-pick of this is also up against `0.87-stable` (react#57553).

## Changelog

[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.


Test Plan:
- `yarn test-release-local -t RNTestProject -p iOS`: app boots without the redbox.
- Bundle tail contains `__r(<InitializeCore>); __r(0);` instead of just `__r(0);`.

Reviewed By: christophpurrer

Differential Revision: D112002434

Pulled By: zeyap
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2026
@meta-codesync

meta-codesync Bot commented Jul 15, 2026

Copy link
Copy Markdown

@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112002434.

@meta-codesync meta-codesync Bot closed this in 08c3233 Jul 15, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Jul 15, 2026
@meta-codesync

meta-codesync Bot commented Jul 15, 2026

Copy link
Copy Markdown

This pull request has been merged in 08c3233.

react-native-bot pushed a commit that referenced this pull request Jul 15, 2026
#57557)

Summary:
Pull Request resolved: #57557

Fresh projects **redbox on launch** — e.g.:

```
Failed to call into JavaScript module method RCTDeviceEventEmitter.emit().
Module has not been registered as callable.
Registered callable JavaScript modules (n = 1): AppRegistry.
```

(The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**.

## Root cause (#57475)

Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise:

```js
const paths = [...options.runBeforeMainModule, entryPoint];
for (const path of paths) {
  if (modules.some((module) => module.path === path)) {  // only if already in the graph
    /* __r(moduleId) */
  }
}
```

**#57475 switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`.

- `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`).
- `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs.

The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. #57498 was cosmetic (same resolved file) and does not fix this.

### Evidence (bundle tail)

| Run-before target | Bundle tail | Boots? |
|---|---|---|
| `setup-env` (current) | `__r(0);` | ❌ |
| `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ |

Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and #57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green.

## Scope — interim stopgap

Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**.

The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner).

A cherry-pick of this is also up against `0.87-stable` (#57553).

## Changelog

[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.

Reviewed By: christophpurrer

Differential Revision: D112002434

fbshipit-source-id: ea3559ef74d31f2c0f9af78aa0a020f4b322e7e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant