Bootstrap Metro from InitializeCore until setup-env is graph-reachable (#57554)#57557
Closed
zeyap wants to merge 1 commit into
Closed
Bootstrap Metro from InitializeCore until setup-env is graph-reachable (#57554)#57557zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
react#57554) Summary: Fresh projects **redbox on launch** — e.g.: ``` Failed to call into JavaScript module method RCTDeviceEventEmitter.emit(). Module has not been registered as callable. Registered callable JavaScript modules (n = 1): AppRegistry. ``` (The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**. ## Root cause (react#57475) Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise: ```js const paths = [...options.runBeforeMainModule, entryPoint]; for (const path of paths) { if (modules.some((module) => module.path === path)) { // only if already in the graph /* __r(moduleId) */ } } ``` **react#57475 switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`. - `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`). - `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs. The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. react#57498 was cosmetic (same resolved file) and does not fix this. ### Evidence (bundle tail) | Run-before target | Bundle tail | Boots? | |---|---|---| | `setup-env` (current) | `__r(0);` | ❌ | | `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ | Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and react#57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green. ## Scope — interim stopgap Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**. The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner). A cherry-pick of this is also up against `0.87-stable` (react#57553). ## Changelog [General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running. Test Plan: - `yarn test-release-local -t RNTestProject -p iOS`: app boots without the redbox. - Bundle tail contains `__r(<InitializeCore>); __r(0);` instead of just `__r(0);`. Reviewed By: christophpurrer Differential Revision: D112002434 Pulled By: zeyap
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112002434. |
|
This pull request has been merged in 08c3233. |
react-native-bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
#57557) Summary: Pull Request resolved: #57557 Fresh projects **redbox on launch** — e.g.: ``` Failed to call into JavaScript module method RCTDeviceEventEmitter.emit(). Module has not been registered as callable. Registered callable JavaScript modules (n = 1): AppRegistry. ``` (The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**. ## Root cause (#57475) Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise: ```js const paths = [...options.runBeforeMainModule, entryPoint]; for (const path of paths) { if (modules.some((module) => module.path === path)) { // only if already in the graph /* __r(moduleId) */ } } ``` **#57475 switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`. - `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`). - `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs. The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. #57498 was cosmetic (same resolved file) and does not fix this. ### Evidence (bundle tail) | Run-before target | Bundle tail | Boots? | |---|---|---| | `setup-env` (current) | `__r(0);` | ❌ | | `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ | Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and #57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green. ## Scope — interim stopgap Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**. The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner). A cherry-pick of this is also up against `0.87-stable` (#57553). ## Changelog [General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running. Reviewed By: christophpurrer Differential Revision: D112002434 fbshipit-source-id: ea3559ef74d31f2c0f9af78aa0a020f4b322e7e0
4 tasks
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fresh projects redbox on launch — e.g.:
(The named module varies —
HMRClient.setup(),RCTDeviceEventEmitter.emit()— it's whichever callable module native calls first.)n = 1: AppRegistryis the tell: core initialization never runs.Root cause (#57475)
Core init runs via Metro's
serializer.getModulesRunBeforeMainModule. Metro (metro/src/lib/getAppendScripts.js) only emits the run-before__r()for a module already present in the bundle graph, and silently skips it otherwise:#57475 switched the run-before target from
Libraries/Core/InitializeCore→src/setup-env.js.InitializeCore.jsis reachable (imported byLibraries/ReactPrivate/ReactNativePrivateInitializeCore.js).src/setup-env.jsis imported by nothing → not in the graph → silently skipped → core init never runs.The two modules are functionally identical (both call
setUpDefaultReactNativeEnvironment().default()), so only reachability changed. #57498 was cosmetic (same resolved file) and does not fix this.Evidence (bundle tail)
setup-env(current)__r(0);InitializeCore(this PR)__r(<InitializeCore>); __r(0);Verified end-to-end via
test-release-local -t RNTestProject -p iOS. Ruled out: Metro cache (cold--reset-cacheidentical), stale Metro, and #57484 (./src/*exports removal). Reproduces via thereact-native-community/clibundling path (OSSreact-native start); internal Meta bundling is unaffected, which is why CI/internal stayed green.Scope — interim stopgap
Only the internal Metro bootstrap target reverts to
InitializeCore. The publicreact-native/setup-enventry point and its deprecation ofInitializeCoreare unchanged.The durable fix is to make
setup-envgraph-reachable (or make Metro treatgetModulesRunBeforeMainModuleentries as graph roots) — which will then allowInitializeCoreto be removed as intended. cc huntie (setup-envstack owner).A cherry-pick of this is also up against
0.87-stable(#57553).Changelog
[General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running.
Test Plan:
yarn test-release-local -t RNTestProject -p iOS: app boots without the redbox.__r(<InitializeCore>); __r(0);instead of just__r(0);.Reviewed By: christophpurrer
Differential Revision: D112002434
Pulled By: zeyap