Added sqlmock-based unit tests for every mysql store file#378
Merged
behinddwalls merged 2 commits intoJul 16, 2026
Merged
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
behinddwalls
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Added sqlmock-based unit tests for every mysql store file in both
stovepipe/extension/storage/mysql/andsubmitqueue/extension/storage/mysql/.What?
Added one
_test.goper store file (17 new files, no production code changed):storage_test.go,build_store_test.go,queue_store_test.go,request_store_test.go(+isDuplicateEntry),request_uri_store_test.go.storage_test.go,build_store_test.go,batch_store_test.go,batch_dependent_store_test.go,change_store_test.go,request_log_store_test.go,request_store_test.go,request_summary_store_test.go(+normalizeChangeURIs/normalizeMetadata),request_queue_summary_store_test.go,request_uri_store_test.go,speculation_path_build_store_test.go,speculation_tree_store_test.go.Test Plan
make build&make test- all cleanIssue