Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions test/integration/extension/counter/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ func (s *CounterContractSuite) TestCounter_Next() {
seq3, err := s.counter.Next(ctx, domain)
require.NoError(t, err)
assert.Equal(t, seq2+1, seq3, "sequence should continue incrementing")

s.log.Logf("Next test passed: %d → %d → %d", seq1, seq2, seq3)
}

// TestCounter_MultipleDomains tests independent counters
Expand All @@ -99,9 +97,6 @@ func (s *CounterContractSuite) TestCounter_MultipleDomains() {
// Each domain should increment independently
assert.Equal(t, seq1a+1, seq1b, "domain1 should increment")
assert.Equal(t, seq2a+1, seq2b, "domain2 should increment")

s.log.Logf("Multiple domains test passed: domain1=%d→%d, domain2=%d→%d",
seq1a, seq1b, seq2a, seq2b)
}

// TestCounter_Concurrency tests concurrent access to the same counter
Expand Down Expand Up @@ -141,7 +136,4 @@ func (s *CounterContractSuite) TestCounter_Concurrency() {
assert.Equal(t, sequences[i-1]+1, sequences[i],
"sequences should be contiguous at index %d: got %d and %d", i, sequences[i-1], sequences[i])
}

s.log.Logf("Concurrency test passed: %d goroutines generated %d contiguous sequences (%d-%d)",
numGoroutines, len(sequences), sequences[0], sequences[len(sequences)-1])
}
16 changes: 0 additions & 16 deletions test/integration/stovepipe/extension/storage/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_Create() {
LatestRequestID: "",
Version: 1,
}, got)

s.log.Logf("Create passed: created queue %s", name)
}

// TestQueueStore_CreateWithFields verifies caller-supplied initial field values are persisted.
Expand All @@ -90,8 +88,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_CreateWithFields() {
got, err := s.queueStore.Get(s.ctx, name)
require.NoError(t, err)
assert.Equal(t, toCreate, got)

s.log.Logf("CreateWithFields passed: persisted fields for queue %s", name)
}

// TestQueueStore_CreateAlreadyExists verifies a duplicate Create returns ErrAlreadyExists.
Expand All @@ -113,8 +109,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_CreateAlreadyExists() {
got, err := s.queueStore.Get(s.ctx, name)
require.NoError(t, err)
assert.Equal(t, first, got)

s.log.Logf("CreateAlreadyExists passed: queue %s", name)
}

// TestQueueStore_GetNotFound verifies Get returns ErrNotFound for a missing queue.
Expand All @@ -123,8 +117,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_GetNotFound() {

_, err := s.queueStore.Get(s.ctx, "contract/does-not-exist")
assert.True(t, storage.IsNotFound(err))

s.log.Logf("GetNotFound passed")
}

// TestQueueStore_UpdateCAS verifies a conditional update persists all mutable fields and rejects stale versions.
Expand All @@ -150,8 +142,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_UpdateCAS() {

err = s.queueStore.Update(s.ctx, updated, 1, 2)
assert.ErrorIs(t, err, storage.ErrVersionMismatch)

s.log.Logf("UpdateCAS passed: queue %s", name)
}

// TestQueueStore_UpdateNotFoundIsVersionMismatch verifies Update on a missing row returns ErrVersionMismatch.
Expand All @@ -160,8 +150,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_UpdateNotFoundIsVersionMismatch

err := s.queueStore.Update(s.ctx, entity.Queue{Name: "contract/missing"}, 1, 2)
assert.ErrorIs(t, err, storage.ErrVersionMismatch)

s.log.Logf("UpdateNotFoundIsVersionMismatch passed")
}

// TestQueueStore_UpdateSequentialCAS verifies successive conditional updates advance version monotonically.
Expand All @@ -182,8 +170,6 @@ func (s *QueueStoreContractSuite) TestQueueStore_UpdateSequentialCAS() {
assert.Equal(t, "request/contract/sequential-cas/10", got.LatestRequestID)
assert.Equal(t, int32(1), got.InFlightCount)
assert.Equal(t, int32(3), got.Version)

s.log.Logf("UpdateSequentialCAS passed: queue %s", name)
}

// TestQueueStore_QueueIsolation verifies updates to one queue do not affect another.
Expand Down Expand Up @@ -212,6 +198,4 @@ func (s *QueueStoreContractSuite) TestQueueStore_QueueIsolation() {
gotB, err := s.queueStore.Get(s.ctx, nameB)
require.NoError(t, err)
assert.Equal(t, baseline, gotB)

s.log.Logf("QueueIsolation passed: queues %s and %s", nameA, nameB)
}
12 changes: 0 additions & 12 deletions test/integration/submitqueue/extension/storage/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ func (s *StorageContractSuite) TestStorage_CreateAndGet() {
assert.Equal(t, request.Change.URIs, retrieved.Change.URIs)
assert.Equal(t, request.LandStrategy, retrieved.LandStrategy)
assert.Equal(t, request.Version, retrieved.Version)

s.log.Logf("CreateAndGet test passed: created and retrieved request %s", request.ID)
}

// TestStorage_CreateAndGet_StackedPRs tests creating and retrieving a request with stacked PRs
Expand Down Expand Up @@ -124,8 +122,6 @@ func (s *StorageContractSuite) TestStorage_CreateAndGet_StackedPRs() {
assert.Equal(t, stackedURIs, retrieved.Change.URIs, "stacked PR URIs should be preserved exactly")
assert.Equal(t, request.ID, retrieved.ID)
assert.Equal(t, request.LandStrategy, retrieved.LandStrategy)

s.log.Logf("CreateAndGet_StackedPRs test passed: %d stacked URIs", len(stackedURIs))
}

// TestStorage_UpdateState tests updating request state
Expand Down Expand Up @@ -154,8 +150,6 @@ func (s *StorageContractSuite) TestStorage_UpdateState() {
require.NoError(t, err)
assert.Equal(t, entity.RequestStateProcessing, retrieved.State)
assert.Equal(t, int32(2), retrieved.Version, "version should increment after update")

s.log.Logf("UpdateState test passed: updated request %s to state %s", request.ID, retrieved.State)
}

// TestStorage_OptimisticLocking tests version-based optimistic locking
Expand Down Expand Up @@ -189,8 +183,6 @@ func (s *StorageContractSuite) TestStorage_OptimisticLocking() {
require.NoError(t, err)
assert.Equal(t, entity.RequestStateProcessing, retrieved.State, "stale update should not modify state")
assert.Equal(t, int32(2), retrieved.Version)

s.log.Logf("Optimistic locking test passed: prevented stale update for request %s", request.ID)
}

// TestStorage_NotFound tests getting a non-existent request
Expand All @@ -202,8 +194,6 @@ func (s *StorageContractSuite) TestStorage_NotFound() {
_, err := s.storage.GetRequestStore().Get(ctx, "test/nonexistent")
assert.Error(t, err, "getting non-existent request should return error")
assert.ErrorIs(t, err, storage.ErrNotFound, "should return ErrNotFound")

s.log.Logf("NotFound test passed: correctly returned ErrNotFound")
}

// TestStorage_CreateDuplicate tests creating a request with duplicate ID
Expand All @@ -227,8 +217,6 @@ func (s *StorageContractSuite) TestStorage_CreateDuplicate() {
err = s.storage.GetRequestStore().Create(ctx, request)
assert.Error(t, err, "creating duplicate request should return error")
assert.ErrorIs(t, err, storage.ErrAlreadyExists, "should return ErrAlreadyExists")

s.log.Logf("CreateDuplicate test passed: prevented duplicate creation")
}

// changeURI is a representative change URI reused across change-store contract tests.
Expand Down
6 changes: 0 additions & 6 deletions test/integration/submitqueue/gateway/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ func (s *GatewayIntegrationSuite) TestPingAPI() {
assert.Equal(t, "gateway", resp.ServiceName)
assert.NotEmpty(t, resp.Message)
assert.NotZero(t, resp.Timestamp)

s.log.Logf("Gateway Ping test passed: %s", resp.Message)
}

// TestLandAPI tests the Gateway Land API with queue publishing
Expand All @@ -162,8 +160,6 @@ func (s *GatewayIntegrationSuite) TestLandAPI() {
err = s.queueDB.QueryRow("SELECT COUNT(*) FROM queue_messages WHERE id = ?", resp.Sqid).Scan(&msgCount)
require.NoError(t, err, "failed to query queue messages")
assert.Equal(t, 1, msgCount, "should have 1 message in queue")

s.log.Logf("Land API test passed: request stored and message published")
}

// TestRequestLogConsumer verifies the gateway's log-topic consumer in isolation:
Expand Down Expand Up @@ -206,6 +202,4 @@ func (s *GatewayIntegrationSuite) TestRequestLogConsumer() {
return resp.Status == string(entity.RequestStatusStarted)
}, persistTimeout, persistPollInterval,
"gateway log consumer should persist the published request log for sqid=%s", sqid)

s.log.Logf("Request log consumer test passed: entry persisted and readable via Status")
}
2 changes: 0 additions & 2 deletions test/integration/submitqueue/orchestrator/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,4 @@ func (s *OrchestratorIntegrationSuite) TestPingAPI() {
assert.Equal(t, "orchestrator", resp.ServiceName)
assert.NotEmpty(t, resp.Message)
assert.NotZero(t, resp.Timestamp)

s.log.Logf("Orchestrator Ping test passed: %s", resp.Message)
}
Loading