Skip to content

chore: standardise internal node on 24.18.0 #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carderne wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: standardise internal node on 24.18.0 #4254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62111f4
chore: standardise internal node on 24.18.0
carderne Jul 14, 2026
a65475b
chore: regenerate fixture yarn lockfile
carderne Jul 14, 2026
5c7f1ce
fix(run-store): avoid Array.at in waitpoint count
carderne Jul 14, 2026
d70b0f8
fix(run-engine): avoid Array.at in queue key parser
carderne Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changesets-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/claude.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dashboard-agent-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: Install + build the CLI and the agent's deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-webapp-auth-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 🐳 Login to DockerHub
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-webapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0

- name: 📥 Download deps
run: pnpm install --frozen-lockfile --filter trigger.dev...
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 📥 Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

# npm v11.5.1 or newer is required for OIDC support
Expand Down Expand Up @@ -303,7 +303,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

# npm v11.5.1 or newer is required for OIDC support
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/sdk-compat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 🥟 Setup Bun
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 🦕 Setup Deno
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
# no cache enabled, we're not installing deps

- name: Download blob reports from GitHub Actions Artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-webapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down Expand Up @@ -160,7 +160,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.23.1
node-version: 24.18.0
# no cache enabled, we're not installing deps

- name: Download blob reports from GitHub Actions Artifacts
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.23.1
v24.18.0
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ branch are tagged into a release periodically.

### Prerequisites

- [Node.js](https://nodejs.org/en) version 22.23.1
- [Node.js](https://nodejs.org/en) version 24.18.0
- [pnpm package manager](https://pnpm.io/installation) version 10.33.2
- [Docker](https://www.docker.com/get-started/)
- [protobuf](https://github.com/protocolbuffers/protobuf)
Expand All @@ -49,7 +49,7 @@ branch are tagged into a release periodically.
```
cd trigger.dev
```
3. Ensure you are on the correct version of Node.js (22.23.1). If you are using `nvm`, there is an `.nvmrc` file that will automatically select the correct version of Node.js when you navigate to the repository.
3. Ensure you are on the correct version of Node.js (24.18.0). If you are using `nvm`, there is an `.nvmrc` file that will automatically select the correct version of Node.js when you navigate to the repository.

4. Run `corepack enable` to use the correct version of pnpm (`10.33.2`) as specified in the root `package.json` file.

Expand Down
2 changes: 1 addition & 1 deletion apps/supervisor/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.23.1
v24.18.0
6 changes: 3 additions & 3 deletions apps/supervisor/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS node-22-alpine
FROM node:24.18.0-alpine@sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd AS node-24-alpine

@devin-ai-integration devin-ai-integration Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Docker image digests should be verified as multiplatform/index digests per repo rules

The AGENTS.md specifies: "Always use multiplatform/index digests, not architecture-specific digests" when updating Docker image references. The PR updates two digests:

  • apps/supervisor/Containerfile:1: sha256:a0b9bf06e4e6193cf7a0f58816cc935ff8c2a908f81e6f1a95432d679c54fbfd
  • docker/Dockerfile:1: sha256:39a4259b6f744868a8228742ad45aa3026f97302e5eec2fa4a38b30ca0a66e12

I cannot verify from the repository alone whether these are multiplatform index digests or architecture-specific ones. If they are arch-specific (e.g., pulled from an amd64 variant page), CI on ARM runners would fail. Worth a quick verification against Docker Hub.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


WORKDIR /app

FROM node-22-alpine AS pruner
FROM node-24-alpine AS pruner

COPY --chown=node:node . .
RUN npx -q turbo@2.10.0 prune --scope=supervisor --docker

FROM node-22-alpine AS base
FROM node-24-alpine AS base

RUN apk add --no-cache dumb-init

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NODE_IMAGE=node:22.23.1-bookworm-slim@sha256:813a7480f28fdadac1f7f5c824bcdad435b5bc1322a5968bbbdef8d058f9dff4
ARG NODE_IMAGE=node:24.18.0-bookworm-slim@sha256:39a4259b6f744868a8228742ad45aa3026f97302e5eec2fa4a38b30ca0a66e12

FROM golang:1.26-alpine AS goose_builder
RUN go install github.com/pressly/goose/v3/cmd/goose@v3.27.1
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/otlp-importer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"typecheck": "tsc --noEmit"
},
"devDependencies": {
"@types/node": "^22.20.0",
"@types/node": "^24.13.3",
"rimraf": "^6.0.1",
"ts-proto": "^1.167.3"
},
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/rbac/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@trigger.dev/database": "workspace:*",
"@types/node": "^22.20.0",
"@types/node": "^24.13.3",
"rimraf": "6.0.1"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/run-engine/src/run-queue/keyProducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export class RunQueueFullKeyProducer implements RunQueueKeyProducer {
projectId: parts[3],
envId: parts[5],
queue: parts[7],
concurrencyKey: parts.at(9),
concurrencyKey: parts[9],
};
}

Expand Down
4 changes: 2 additions & 2 deletions internal-packages/run-store/src/PostgresRunStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2094,7 +2094,7 @@ export class PostgresRunStore implements RunStore {
WHERE id = ANY(${waitpointIds}::text[])
AND status = 'PENDING'
`;
return Number(pendingCheck.at(0)?.pending_count ?? 0);
return Number(pendingCheck[0]?.pending_count ?? 0);
}

const pendingCheck = await prisma.$queryRaw<{ pending_count: bigint }[]>`
Expand All @@ -2103,7 +2103,7 @@ export class PostgresRunStore implements RunStore {
WHERE id IN (${Prisma.join(waitpointIds)})
AND status = 'PENDING'
`;
return Number(pendingCheck.at(0)?.pending_count ?? 0);
return Number(pendingCheck[0]?.pending_count ?? 0);
}

async createWaitpoint<T extends Prisma.WaitpointCreateArgs>(
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/sso/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@trigger.dev/database": "workspace:*",
"@types/node": "^22.20.0",
"@types/node": "^24.13.3",
"rimraf": "6.0.1"
},
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@manypkg/cli": "^0.19.2",
"@playwright/test": "^1.36.2",
"@trigger.dev/database": "workspace:*",
"@types/node": "22.20.0",
"@types/node": "24.13.3",
Comment thread
carderne marked this conversation as resolved.
"@vitest/coverage-v8": "4.1.7",
"autoprefixer": "^10.4.12",
"knip": "6.25.0",
Expand Down Expand Up @@ -94,7 +94,7 @@
},
"overrides": {
"typescript": "5.5.4",
"@types/node": "22.20.0",
"@types/node": "24.13.3",
"react@^18": "18.3.1",
"react-dom@^18": "18.3.1",
"ai@^6": "6.0.116",
Expand Down
16 changes: 8 additions & 8 deletions packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"devDependencies": {
"@trigger.dev/build": "0.0.0-prerelease-20250321122618",
"@types/node": "^22.20.0",
"@types/node": "^24.13.3",
"typescript": "5.5.4"
}
}
Loading
Loading