Retry failed container removals (JVMHookResourceReaper)#11561
Open
MikeEdgar wants to merge 1 commit into
Open
Conversation
MikeEdgar
force-pushed
the
jvmhook-retry-removal-2.x
branch
from
4e9fe98 to
da0ca33
Compare
MikeEdgar
force-pushed
the
jvmhook-retry-removal-2.x
branch
from
da0ca33 to
4946e86
Compare
MikeEdgar
force-pushed
the
jvmhook-retry-removal-2.x
branch
from
4946e86 to
e907079
Compare
Author
|
Any reviewers available to comment on this change? @eddumelendez please take a look if you have a chance 🙏 |
Signed-off-by: Michael Edgar <medgar@redhat.com>
MikeEdgar
force-pushed
the
jvmhook-retry-removal-2.x
branch
from
e907079 to
86a449c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change tightens up the processing in the
JVMHookResourceReaperwith error handling and up to 5 tries when removing container images. This fixes a problem in podman where containers may have dependencies and one or more may fail to be removed initially. A subsequent pass over existing containers will remove those that failed initially, provided the dependent container was removed.