fix(runner): error-handling & robustness (timeouts, polling, clone check)#148
Open
lfrancke wants to merge 1 commit into
Open
fix(runner): error-handling & robustness (timeouts, polling, clone check)#148lfrancke wants to merge 1 commit into
lfrancke wants to merge 1 commit into
Conversation
- command.py: the TimeoutExpired path returned a bare string while every other path returns a list of lines; callers iterate the output, so a timeout message was logged one character per line. Return a list. - provider_ionos/provider_replicated: the "wait for state" loops polled forever. A stuck API state hung the Jenkins executor and prevented terminate_cluster() from running, leaking billable cloud resources. They now honour a timeout (30 min) and return True/False; create_cluster aborts (returns None) when a wait times out. - operator-test-runner: check clone_git_repo()'s result; on failure, terminate the already-created cluster and abort instead of proceeding into a confusing SDP-install error. - jenkins-job-builder: add a 30s timeout to the per-operator tag lookup so a slow registry can't hang the whole job. - cluster.py: log and return on an unknown provider id instead of silently returning None/no-op. - Deduplicate the identical write_cluster_info_file() into command.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctness / robustness fixes in the test-runner apps
command.pytimeout returns a string, not a list — every other return path returns a list of lines; callers dofor line in output: logger(line), so a timeout message was logged one character per line (exactly on the retried, long-running commands). Now returns a list.provider_ionos.pydatacenter/cluster/nodepool,provider_replicated.pyrunning-cluster) —while state != target: sleep(5)looped forever. A stuck API state hung the Jenkins executor and preventedterminate_cluster()from running, leaking billable IONOS resources. They now honour a 30-min timeout and returnTrue/False;create_clusteraborts (returnsNone) on timeout.clone_git_repo()result ignored (operator-test-runner.py) — a failed clone let the run continue after the cluster was created, surfacing later as a confusing SDP-install error. Now it terminates the cluster and aborts.jenkins-job-builder.py, 16× loop) — addedtimeout=30.cluster.pysilently returnedNone/no-op — now logs and returns.write_cluster_info_file()intocommand.py.Verification
ruff check apps/clean; all six files parse.list; a wait that never reaches its target returnsFalseat the deadline instead of looping.Independent of the other follow-up PRs (touches the same files as the security PR but different lines).