various fixes for RubyParser#4166
Open
zenspider wants to merge 4 commits into
Open
Conversation
5351eeb to
e077752
Compare
e077752 to
d98f0ab
Compare
Member
Author
|
Added an optional commit to update the tests to current. I can pull it to a different PR to keep this discussion scoped. |
Collaborator
|
Generally adding failures to excludes in If I run the import, I also get |
Member
Author
|
@Earlopain prolly gets swallowed as I'm on APFS and it is case insensitive by default... but since that commit broke EVERYTHING I should prolly punt it for now |
47c3578 to
d98f0ab
Compare
Collaborator
|
I'm seeing a couple of changes in here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
One thing this doesn't have is the ACTUAL fixes I want for parser changes, because that would cause failures in the tests against RubyParser.
Is there a plan for how to deal with drift if I'm hoping to EOL RubyParser? Add them to
known_failures?Also, it looks like an import hasn't been for some time, and maybe the last one was done against git and not against a release... I'm hesitant to add/change those files as I'm not sure I'm doing the process correctly: