chore(deps): upgrade Rslib to v1.0.0-beta.0#43
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe configuration loader now returns 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a439d3e8a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!libConfig) { | ||
| // TODO: should allow empty object to be returned | ||
| return { lib: [{}] }; | ||
| return {}; |
There was a problem hiding this comment.
Don't treat explicit falsy lib configs as omitted
When a JavaScript config calls define.lib(null) or define.lib(false), configs.lib is explicitly present but this path now returns the omitted-config default {} and lets Rslib build the default library instead of validating the bad value. Since this upgrade relies on Rslib's new distinction between omitted lib and invalid explicit values, check for undefined/presence rather than all falsy values so invalid configs still fail fast.
Useful? React with 👍 / 👎.
Summary
This PR upgrades Rslib to v1.0.0-beta.0 to adopt its latest pre-release behavior and compatibility updates.
When
define.libis omitted, Rstack now returns an empty Rslib config and relies on Rslib's new default library output instead of injectinglib: [{}].Related Links