fix(config): make platformCommit global-only#44585
Conversation
platformCommit global-only
2976fe7 to
5f856e1
Compare
|
👍 |
|
We have a use-case for GitHub has a (from what I can find) undocumented limit on the number of files that can be created with the https://docs.github.com/en/rest/git/trees?apiVersion=2026-03-10 endpoint. Normally, we don't hit that limit, and we can use However, one of our internal packages decided that they wanted to add around 900 files to consuming repositories when the package was updated (using While I don't necessarily agree with that package's decisions, this is a configuration workaround that allows them to do it. |
Do not make platformCommit global-only. Restore CommitFilesConfig threading and GithubScm reading commitConfig.platformCommit so rules can still set platformCommit per package (see renovatebot#44585 discussion).
|
@jonathanmorley, that's super useful feedback, thank you! I'm closing this PR as I don't want to cause any regression. |
Changes
This PR changes
platformCommitso that it's a global-only option rather than repository-level.I believe this only makes sense.
/cc @zharinov
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Used Grok Build 4.5 for implementing this.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A