Skip to content

fix(config): make platformCommit global-only#44585

Closed
felipecrs wants to merge 1 commit into
renovatebot:mainfrom
felipecrs:fix/platformCommit-global-only
Closed

fix(config): make platformCommit global-only#44585
felipecrs wants to merge 1 commit into
renovatebot:mainfrom
felipecrs:fix/platformCommit-global-only

Conversation

@felipecrs

@felipecrs felipecrs commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Changes

This PR changes platformCommit so that it's a global-only option rather than repository-level.

I believe this only makes sense.

/cc @zharinov

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Used Grok Build 4.5 for implementing this.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: N/A

@felipecrs felipecrs changed the title fix(config): make platformCommit global-only fix(config): make platformCommit global-only Jul 14, 2026
@felipecrs felipecrs marked this pull request as ready for review July 14, 2026 19:22
@github-actions github-actions Bot requested a review from viceice July 14, 2026 19:22
@felipecrs felipecrs force-pushed the fix/platformCommit-global-only branch from 2976fe7 to 5f856e1 Compare July 14, 2026 19:23
@zharinov

Copy link
Copy Markdown
Collaborator

👍

@jonathanmorley

jonathanmorley commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

We have a use-case for platformCommit in packageRules:

GitHub has a (from what I can find) undocumented limit on the number of files that can be created with the https://docs.github.com/en/rest/git/trees?apiVersion=2026-03-10 endpoint.

Normally, we don't hit that limit, and we can use platformCommit: true.

However, one of our internal packages decided that they wanted to add around 900 files to consuming repositories when the package was updated (using postUpgradeTasks). This hit the limit, and so we used platformCommit: false in a packageRule scoped to that package to allow them to proceed.

While I don't necessarily agree with that package's decisions, this is a configuration workaround that allows them to do it.

felipecrs added a commit to felipecrs/renovate that referenced this pull request Jul 14, 2026
Do not make platformCommit global-only. Restore CommitFilesConfig
threading and GithubScm reading commitConfig.platformCommit so rules
can still set platformCommit per package (see renovatebot#44585 discussion).
@felipecrs

Copy link
Copy Markdown
Contributor Author

@jonathanmorley, that's super useful feedback, thank you!

I'm closing this PR as I don't want to cause any regression.

@felipecrs felipecrs closed this Jul 14, 2026
@felipecrs felipecrs deleted the fix/platformCommit-global-only branch July 14, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants