feat(copier): convert ssh _src_path to https URL for datasource lookup#44552
Open
jfra1397 wants to merge 1 commit into
Open
feat(copier): convert ssh _src_path to https URL for datasource lookup#44552jfra1397 wants to merge 1 commit into
jfra1397 wants to merge 1 commit into
Conversation
Convert SSH-style template URLs to their HTTPS equivalent when constructing the packageName for the git-tags datasource lookup, mirroring what the git-submodules manager does. This allows the lookup to be authenticated via hostRules credentials on setups which access the Git host over HTTPS only. The answers file itself keeps the original URL, so local 'copier update' runs by developers continue to use SSH. Discussed in renovatebot#44528
51fe471 to
1ccd4fe
Compare
viceice
approved these changes
Jul 14, 2026
Member
|
please check lint failure |
Author
The failure isn't lint — all lint-* jobs passed. build-docs timed out in its "Setup uv" step fetching the uv version manifest (The operation was aborted due to timeout), before building anything: https://github.com/renovatebot/renovate/actions/runs/29316655295/job/87032381528 |
Collaborator
|
@jfra1397 If you merge from main, the jobs should re-run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
copiermanager now converts SSH-style_src_pathURLs (scp-stylegit@host:path,ssh://,git+ssh://) to their HTTPS equivalent when constructing thepackageNamefor thegit-tagsdatasource lookup — mirroring what thegit-submodulesmanager already does viagetHttpUrl().This way the version lookup can be authenticated via
hostRulescredentials on setups which access the Git host over HTTPS only (no SSH key on the bot). Previously, such setups failed with:while an SSH submodule in the same repository resolved fine — a surprising asymmetry.
Details:
depNamekeeps the original_src_pathfor display; only the lookuppackageNamechanges.http(s)URLs are left untouched (no behavior change).copier updateruns by developers continue to use SSH. TheupdateArtifactsstep already handles SSH URLs via the exported gitinsteadOfenvironment directives./scm/segment (handled bygetHttpUrl()).As suggested by the maintainer in #44528 ("Sounds good. PR welcome").
Context
Please select one of the following:
Discussed in #44528. Related: #41725 stripped the
git+prefix but did not address SSH→HTTPS resolution.AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Code, tests and documentation were written with Claude Code (Claude Opus 4.8), reviewed and verified by me.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: