fix(post-upgrade): preserve executable file modes#44505
Open
zharinov wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
postUpgradeTasks.fileFilterscollected changed file contents without their executable state. As a result, a generated executable file orchmod +xchange could still be committed as100644.When Git's per-repository
core.fileModesetting says filesystem modes are reliable, preserve the owner's execute bit by recordingisExecutable: true. Otherwise leave the mode unspecified so the existing Git index state remains unchanged. This fix is intentionally additive and does not implement executable removal.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Model used: GPT 5.6 Sol
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: Not applicable.