Skip to content

fix(post-upgrade): preserve executable file modes#44505

Open
zharinov wants to merge 9 commits into
renovatebot:mainfrom
zharinov:fix/44501-post-upgrade-executable
Open

fix(post-upgrade): preserve executable file modes#44505
zharinov wants to merge 9 commits into
renovatebot:mainfrom
zharinov:fix/44501-post-upgrade-executable

Conversation

@zharinov

@zharinov zharinov commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Changes

postUpgradeTasks.fileFilters collected changed file contents without their executable state. As a result, a generated executable file or chmod +x change could still be committed as 100644.

When Git's per-repository core.fileMode setting says filesystem modes are reliable, preserve the owner's execute bit by recording isExecutable: true. Otherwise leave the mode unspecified so the existing Git index state remains unchanged. This fix is intentionally additive and does not implement executable removal.

Context

Please select one of the following:

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Model used: GPT 5.6 Sol

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: Not applicable.

@zharinov zharinov marked this pull request as ready for review July 11, 2026 21:40
@github-actions github-actions Bot requested a review from viceice July 11, 2026 21:41
@zharinov zharinov marked this pull request as draft July 11, 2026 22:45
@github-actions github-actions Bot removed the request for review from viceice July 11, 2026 22:46
@zharinov zharinov marked this pull request as ready for review July 11, 2026 22:46
@github-actions github-actions Bot requested a review from viceice July 11, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

postUpgradeTasks fileFilters drop the executable bit

1 participant