refactor(http-mock): Remove request tracing#44482
Open
zharinov wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a prerequisite for running Renovate's tests under Bun.
httpMock.getTrace()exposes a Nock-specific request-observation layer. Tests using it depend on synthesized headers, buffered request bodies, GraphQL parsing, request ordering, and recording timing. A Bun-compatible HTTP mock would otherwise need to reproduce those incidental behaviors.This PR removes that API and moves assertions to the request boundary:
reqheadersandbadheaders.The unused GraphQL snapshot helper is removed. Contract tests cover strict cleanup and ensure diagnostics do not expose request headers or bodies.
This does not change production behavior. Transport headers and ordering between unrelated successful requests are intentionally not treated as test contracts.
Context
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
GPT-5.6 Sol implemented the refactor and updated the tests.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A