fix(iOS): classify CFNetwork as a system framework in the header include-health ratchet#57565
Closed
cipolleschi wants to merge 1 commit into
Closed
fix(iOS): classify CFNetwork as a system framework in the header include-health ratchet#57565cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
…ude-health ratchet The compose-xcframework job's "Verify composed headers" step failed the include-health ratchet with two NEW unresolvable includes: unresolved CoreModules/RCTInspectorWebSocketReporter.h -> CFNetwork/CFNetwork.h unresolved React/RCTInspectorWebSocketReporter.h -> CFNetwork/CFNetwork.h RCTInspectorWebSocketReporter.h (#57543) imports <CFNetwork/CFNetwork.h> for CFHTTPMessageRef. CFNetwork is a real Apple system framework, always available in the SDK, but it was missing from the SDK_PREFIXES allowlist in headers-inventory.js, so the ratchet classified the include as unresolvable. Adding it alongside CoreFoundation/Security/Network fixes the classification; no baseline change is needed.
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D112115176. |
chrfalch
approved these changes
Jul 15, 2026
cortinico
approved these changes
Jul 15, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cipolleschi merged this pull request in 724fbdd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the SwiftPM stack landed (#57332), the
prebuild_react_native_core / compose-xcframeworkjobs (Debug and Release) went red on the "Verify composed headers" step (headers-verify.js), not on the XCFramework compile:React/CoreModules/RCTInspectorWebSocketReporter.h(added in #57543, "Add CDP support for WebSocket events (iOS)") does#import <CFNetwork/CFNetwork.h>because it usesCFHTTPMessageRef. The include-health ratchet classifies any include whose first path segment isn't in theSDK_PREFIXESallowlist inheaders-inventory.jsasunresolved.CFNetworkwas missing from that allowlist — even though it's a genuine Apple system framework that's always available in the SDK, exactly likeCoreFoundation,Security, andNetwork, which are already listed. (Two offenders because the same header ships under two natural paths,CoreModules/andReact/.)Fix
Add
CFNetworktoSDK_PREFIXES. This is the accurate classification (it's a system framework), so no baseline change is required.Changelog:
[INTERNAL] [FIXED] - Classify
CFNetworkas a system framework in the prebuilt-header include-health ratchetTest Plan
headers-include-baseline.json:CFNetworkis no longer flagged, 0 new offenders, 0 baseline entries to shrink.ios-prebuildunit suite: 56/56 pass.