Skip to content

avoid copying extended file attributes when inside virtiofs #57555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etodanik wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −4
Open

avoid copying extended file attributes when inside virtiofs #57555

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14d23b7
avoid copying extended file attributes when inside virtiofs
etodanik Jul 14, 2026
8f78f89
fix the if check always resolving as true
etodanik Jul 14, 2026
6a846d8
Only check for virtiofs on MacOS
etodanik Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/react-native-codegen/scripts/oss/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,20 @@ fi
YARN_BINARY="${YARN_BINARY:-$YARN_OR_NPM}"

# mv command to use when copying files into the working directory
EDEN_SAFE_MV="mv"
SAFE_MV="mv"

# Detect if we are on a VirtioFS volume via Apple Virtualization.framework
if [[ "$OSTYPE" == "darwin"* ]] && /sbin/mount | /usr/bin/awk -v dev="$(/bin/df -P "$CODEGEN_DIR" | /usr/bin/awk 'NR==2 {print $1}')" '$1 == dev && /AppleVirtIOFS/ { found=1 } END { exit !found }'; then
SAFE_MV="/bin/cp -R -X"
fi

if [ -x "$(command -v eden)" ]; then
pushd "$THIS_DIR"

# Detect if we are in an EdenFS checkout with `eden info` (we ignore the output as it creates noise on CI/IDE logs)
# Also be sure to use /bin/cp in case users have GNU coreutils installed which is incompatible with -X
if [[ "$OSTYPE" == "darwin"* ]] && eden info 2>/dev/null; then
EDEN_SAFE_MV="/bin/cp -R -X"
SAFE_MV="/bin/cp -R -X"
fi

popd >/dev/null
Expand Down Expand Up @@ -71,7 +76,7 @@ else

popd >/dev/null

$EDEN_SAFE_MV "$TMP_DIR/lib" "$CODEGEN_DIR"
$EDEN_SAFE_MV "$TMP_DIR/node_modules" "$CODEGEN_DIR"
$SAFE_MV "$TMP_DIR/lib" "$CODEGEN_DIR"
$SAFE_MV "$TMP_DIR/node_modules" "$CODEGEN_DIR"
rm -rf "$TMP_DIR"
fi
Loading