Skip to content

[ExecuTorch][Vulkan] Tests for et_vk.linear_q4gsw_backward#20944

Open
JCNTH wants to merge 3 commits into
gh/JCNTH/83/basefrom
gh/JCNTH/83/head
Open

[ExecuTorch][Vulkan] Tests for et_vk.linear_q4gsw_backward#20944
JCNTH wants to merge 3 commits into
gh/JCNTH/83/basefrom
gh/JCNTH/83/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 14, 2026

Copy link
Copy Markdown

Stack from ghstack (oldest at bottom):

Correctness tests for the Vulkan et_vk.linear_q4gsw_backward kernel (stacked above the op diff).

Coverage: the golden d_x = d_out @ dequant(W) is computed with ATen (matmul over the library-dequantized weight), mirroring the CPU-eager linear_q4gsw_backward_impl in custom_ops_lib.py — never a hand-rolled matmul. The packed weight is fed as a constant tensorref so the op exercises the real prepack_q4_w_4x8_nc_buffer W_4X8 path.

Cases:

  • test_tile_aligned — single group, tile-aligned M/N/K.
  • test_grouped — multiple quantization groups along K.
  • test_odd_n4_partial_mN % 8 != 0 (odd N4 -> padded W_4X8 stride) plus a partial-M tile (exercises the min() clamps).

Also wires quantized_linear_backward_test into targets.bzl + CMakeLists.txt (mirrors the sibling linear_q4gsw_dw_test).
@exported-using-ghexport

Differential Revision: D111797530

Differential Revision: D111797530

[ghstack-poisoned]
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jul 14, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20944

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Unrelated Failure

As of commit 820c86f with merge base 7013c8d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 14, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2026
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant