gh-153768: Fix sqlite3 CLI completion for database names with quotes#153770
Open
lkk7 wants to merge 1 commit into
Open
gh-153768: Fix sqlite3 CLI completion for database names with quotes#153770lkk7 wants to merge 1 commit into
lkk7 wants to merge 1 commit into
Conversation
lkk7
commented
Jul 15, 2026
| '\x1b[35mnear "sel": syntax error\x1b[0m', err) | ||
|
|
||
|
|
||
| class Completer(unittest.TestCase): |
Contributor
Author
There was a problem hiding this comment.
Added a new test class because the existing class below is a bit too "end-to-end", while those tests just test the _complete function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153768
Attached database names can contain
"or'quotes, and it breaks table completion.Escape schema names as SQL identifiers or string literals, and add tests for both cases.