Skip to content

gh-43720: IDLE - use tk text print when available #153744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
terryjreedy wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

gh-43720: IDLE - use tk text print when available #153744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d3aab2
gh-43720: IDLE - use tk text print when available
terryjreedy Jul 15, 2026
f44272d
blurb
terryjreedy Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/idlelib/iomenu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,12 @@ def encode(self, chars):
return chars.encode('utf-8-sig')

def print_window(self, event):
try:
self.text.tk.call('tk', 'print', self.text)
except tkinter.TclError:

@serhiy-storchaka serhiy-storchaka Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tkinter import here.

Larger issue is that this catches all TclError; if tk print exists but fails mid-print, it will silently pop up a second dialog. I suggest to check for "unknown subcommand" in the error message, or, better, test the Tk version. Anyway, you need to handle TclError in tk_print() if they are not already handled at higher level.

self.old_print(event)

def old_print(self, event):
confirm = messagebox.askokcancel(
title="Print",
message="Print to Default Printer",
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2026-07-15-01-29-18.gh-issue-43720.a2C8SZ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use tk text print when running tk 9.0+. Patch by Terry J. Reedy.
Loading