Run package substitution tests outside the parallel suite#1276
Open
gerrod3 wants to merge 1 commit into
Open
Conversation
Tests that upload a different artifact under the shelf-reader tar.gz filename leave incorrect global content that can break parallel PyPI JSON checks. Legit shelf-reader uploads and syncs remain parallel. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
jobselko
reviewed
Jul 15, 2026
Comment on lines
203
to
276
| @@ -272,7 +271,6 @@ def test_disallow_package_substitution( | |||
| assert repo.latest_version_href.endswith("/2/") | |||
|
|
|||
|
|
|||
| @pytest.mark.parallel | |||
| def test_package_substitution_allowed_by_default( | |||
| monitor_task, | |||
| python_bindings, | |||
Member
There was a problem hiding this comment.
Is it safe to omit delete_orphans_pre here?
Contributor
Author
There was a problem hiding this comment.
If other tests need a clean Pulp then they should call delete_orphans_pre. The general thinking behind tests is that they should remove any object they create, but artifacts and content are fine to leave hanging around.
jobselko
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pytest.mark.parallelfromtest_disallow_package_substitutionandtest_package_substitution_allowed_by_defaultshelf-reader-0.1.tar.gzfilename, leaving incorrect global content that breaks parallel PyPI JSON checks (e.g.test_pypi_json)Test plan
test (pulp)withouttest_pypi_jsondigest mismatchesMade with Cursor