Fix blank pages from cached CORS rejection#1971
Open
philip wants to merge 1 commit into
Open
Conversation
philip
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1955
Requests with an unrecognized Origin header hit exit(10), which returned an empty 200 with no Cache-Control. The CDN cached that blank page and served it from the affected nodes for 30 days (required manual purge to fix), even to requests sending no Origin at all. Now we skip the CORS headers and serve the page normally.