perf: don't copy zend_constants into every threads EG(zend_constants) table#22729
Open
henderkes wants to merge 2 commits into
Open
perf: don't copy zend_constants into every threads EG(zend_constants) table#22729henderkes wants to merge 2 commits into
henderkes wants to merge 2 commits into
Conversation
…onstants) by falling back to a global constant table before: zend_constants copied all constants into each threads EG(zend_constants) after: zend_constants stays in a global, per-thread EG(zend_constants) becomes a small per-thread lookup table for define/dl and a runtime read falls back to the global when the per-thread table doesn't contain the key
# Conflicts: # ext/reflection/php_reflection.c
henderkes
force-pushed
the
perf/zts_thread_alloc
branch
from
320a999 to
cd67e83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead keep the immutable variables in a global and perform a two-step lookup (thread local EG(zend_constants) still holds
define'd anddl()symbols - if none exist it's still one lookup on only the global table)this is most useful for frankenphp thread scaling scenarios where a large number of threads can be spun up momentarily, or of course ext-parallel
saves 846k instructions and 135kb (plus the allocations that go with it) per thread spawn on x86_64-linux-gnu. I didn't test aarch64