Skip to content

events: inline hybrid dispatch closures#64473

Open
slagiewka wants to merge 2 commits into
nodejs:mainfrom
slagiewka:et
Open

events: inline hybrid dispatch closures#64473
slagiewka wants to merge 2 commits into
nodejs:mainfrom
slagiewka:et

Conversation

@slagiewka

Copy link
Copy Markdown

lib: inline createEvent hybrid dispatch closure

Originally added in 16b11cd, it first
had three callers. Now there's only one branch requireing it.

lib: inline iterationCondition hybrid dispatch closure

While more readable, the removed closure overhead unlocks 10-20% in
eventtarget.js benchmark (30 runs).

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 13, 2026
@slagiewka

Copy link
Copy Markdown
Author

Looks like the convention for commit scope here is either events or lib. I'm fine with both, LMK and I will rewrite these commits.

Originally added in 16b11cd, it first
had three callers. Now there's only one branch requireing it.

Signed-off-by: Szymon Łągiewka <slagiewka@users.noreply.github.com>
While more readable, the removed closure overhead unlocks 10-20% in
eventtarget.js benchmark.

Signed-off-by: Szymon Łągiewka <slagiewka@users.noreply.github.com>
@slagiewka slagiewka changed the title lib: inline hybrid dispatch closures events: inline hybrid dispatch closures Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants