fix(text): support piped messages on Windows#106
Merged
Conversation
- use the standard input file descriptor instead of /dev/stdin - reuse the shared file-or-stdin reader in text chat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dev/stdinpath with the cross-platform stdin file descriptorbl text chat1.8.3package and skill versions with matching English and Chinese changelog entriesRoot cause
bl text chat --messages-file -translated the stdin sentinel to/dev/stdin. On Windows, Node treated that as a path on the current drive, so the command failed locally withENOENTbefore sending an API request.User impact
Piped JSON messages supplied through
--messages-file -now work on Windows while preserving existing file-path behavior on all platforms.Validation
vp checkpnpm --filter bailian-cli-commands exec vp test tests/e2e/text-chat.e2e.test.ts(4/4 passed)CI=true node tools/release/check.mjs(build, generated assets, pack, publint, and gitleaks passed)Closes #103