refactor!: Pass TemplateRepoRequest by value in Repositories.CreateFromTemplate#4378
Open
JamBalaya56562 wants to merge 2 commits into
Open
Conversation
…eFromTemplate` Towards google#3644. BREAKING CHANGE: Repositories.CreateFromTemplate now takes TemplateRepoRequest by value, and TemplateRepoRequest.Name is now a non-pointer string.
gmlewis
added
NeedsReview
gmlewis
approved these changes
Jul 10, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @JamBalaya56562!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4378 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 193 193
Lines 19526 19526
=======================================
Hits 19040 19040
Misses 268 268
Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexandear
reviewed
Jul 14, 2026
| @@ -621,7 +621,7 @@ func (s *RepositoriesService) Create(ctx context.Context, org string, repo *Repo | |||
| // TemplateRepoRequest represents a request to create a repository from a template. | |||
| type TemplateRepoRequest struct { | |||
| // Name is required when creating a repo. | |||
Contributor
There was a problem hiding this comment.
This comment is redundant and can be removed.
Suggested change
| // Name is required when creating a repo. |
Contributor
Author
There was a problem hiding this comment.
Done, removed the redundant comment.
| Name string `json:"name"` | ||
| Owner *string `json:"owner,omitempty"` | ||
| Description *string `json:"description,omitempty"` | ||
|
|
Contributor
There was a problem hiding this comment.
Let's remove this empty line:
Suggested change
Contributor
Author
There was a problem hiding this comment.
Done, removed the empty line.
Addresses review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3644.
Repositories.CreateFromTemplatenow takes itsTemplateRepoRequestbody by value instead of by pointer, and the requirednameproperty becomes a non-pointerstring(itsomitemptyis dropped), so the required body is enforced at compile time.The OpenAPI schema for
POST /repos/{template_owner}/{template_repo}/generatelistsnameas the only required property, and its properties (owner,name,description,include_all_branches,private) map 1:1 to the struct — no fields are missing, so nothing is added.TemplateRepoRequestis removed from theparamcheckbody-allowed-pointer-typesallowlist in.golangci.yml, and the generated accessors are regenerated (GetNamenow returns the value directly).