test: cover preset constitution seeding through init CLI by github-actions[bot] · Pull Request #3297 · github/spec-kit

github-actions · 2026-07-01T18:12:27Z

Summary

Adds CLI-level regression coverage for the constitution preset behavior implemented by #3276.

The test runs specify init --preset <local-path> and verifies that .specify/memory/constitution.md is seeded from a preset whose manifest declares a non-conventional template path.

This complements the existing resolver-level tests by covering the complete init flow, including:

preset installation occurring before constitution materialization;
local preset path handling;
manifest-declared constitution template paths; and
the final memory constitution content.

Scope

This PR contains no production-code changes relative to main. Issue #3272 was resolved by #3276.

Verification

Targeted CLI and constitution resolver tests pass.
Ruff checks pass.

Authored by GitHub Copilot (model: GPT-5.6 Sol) acting autonomously on behalf of @BenBtg.

…tion setup Apply the remediation from the bug assessment on issue #3272. Changes: 1. Modify ensure_constitution_from_template (init.py) to resolve the constitution-template through the preset priority stack via PresetResolver, instead of hardcoding the core template path. This ensures a preset's replacement constitution-template is used when seeding .specify/memory/constitution.md. 2. Reorder init flow: move ensure_constitution_from_template to after the preset installation block so that 'specify init --preset' seeds the memory file from the already-resolved template stack, not from the generic template that existed before the preset arrived. 3. Add _maybe_reseed_constitution to PresetManager (presets/__init__.py): a post-install hook that re-seeds .specify/memory/constitution.md from the preset's constitution-template during 'specify preset add' on an existing project, but only when the memory file still contains generic placeholder tokens ([PROJECT_NAME] or [PRINCIPLE_1_NAME]). Legitimately authored constitutions (no placeholder tokens) are never overwritten. 4. Add regression tests covering both code paths (TestConstitutionReseedOnPresetInstall and TestEnsureConstitutionFromTemplate in tests/test_presets.py). Refs #3272 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Fixes preset-aware constitution seeding during initialization and preset installation.

Changes:

Resolves constitution templates through PresetResolver.
Reorders initialization and adds guarded post-install reseeding.
Adds constitution seeding and preservation tests.

Show a summary per file

File	Description
`src/specify_cli/commands/init.py`	Adds preset-aware constitution resolution and reorders seeding.
`src/specify_cli/presets/__init__.py`	Adds post-install constitution reseeding.
`tests/test_presets.py`	Tests constitution resolution and overwrite guards.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 5
Review effort level: Medium

Use manifest-aware composed content, atomic safe writes, and conservative generic-template matching for constitution seeding and re-seeding. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49891a32-bec4-462c-a7f2-6d6ec4eefcdb

BenBtg · 2026-07-15T14:08:15Z

Consolidated the duplicate implementation from #3298 into this branch and hardened the resolution path in commit e601a6e. The final implementation uses manifest-aware composed content, exact generic-template matching, pre-read symlink validation, atomic writes, warned best-effort failure handling, and CLI-level regression coverage.\n\nPosted on behalf of @BenBtg by GitHub Copilot (model: GPT-5.6 Sol).

Resolve constitution implementation conflicts in favor of the provenance-based fix now on main while retaining CLI-level regression coverage for manifest-declared preset paths. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49891a32-bec4-462c-a7f2-6d6ec4eefcdb

Copilot

Review details

Files reviewed: 1/1 changed files
Comments generated: 0 new
Review effort level: Medium

Remove accidental whole-file Ruff formatting introduced during conflict resolution so the PR contains only the intended end-to-end test. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49891a32-bec4-462c-a7f2-6d6ec4eefcdb

Copilot

Review details

Comments suppressed due to low confidence (1)

tests/integrations/test_cli.py:313

PresetManager.install_from_directory() already calls _seed_constitution_from_preset() (src/specify_cli/presets/__init__.py:1742-1749), so this test's constitution is created during installation; the later init-level ensure_constitution_from_template() only preserves the existing file. Consequently, moving or removing the post-install materialization still passes, so the ordering claimed by this regression test is not covered. Disable the lifecycle seeding hook here (or instrument the init helper) so the final assertion depends on init materializing after the preset is registered.

        """Pre-existing shared files are not overwritten without --force."""
        from specify_cli import _install_shared_infra

        project = tmp_path / "skip-test"
        project.mkdir()

Files reviewed: 1/1 changed files
Comments generated: 0 new
Review effort level: Medium

Disable preset-install lifecycle seeding in the regression test so it fails unless init materializes the constitution after registering the preset. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 49891a32-bec4-462c-a7f2-6d6ec4eefcdb

Copilot

Review details

Files reviewed: 1/1 changed files
Comments generated: 0 new
Review effort level: Medium

github-actions Bot added automated bug-fix Trigger the bug-fix agentic workflow labels Jul 1, 2026

github-actions Bot mentioned this pull request Jul 1, 2026

Preset constitution-template (strategy: replace) is not installed, and speckit.constitution is not preset-aware #3272

Closed

BenBtg self-assigned this Jul 6, 2026

BenBtg requested a review from Copilot July 13, 2026 15:07

Copilot started reviewing on behalf of BenBtg July 13, 2026 15:08 View session

BenBtg marked this pull request as ready for review July 13, 2026 15:10

BenBtg requested a review from mnriem as a code owner July 13, 2026 15:10

BenBtg marked this pull request as draft July 13, 2026 15:10

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/specify_cli/commands/init.py Outdated

Comment thread src/specify_cli/presets/__init__.py Outdated

Comment thread src/specify_cli/presets/__init__.py Outdated

Comment thread src/specify_cli/presets/__init__.py Outdated

Comment thread src/specify_cli/commands/init.py

BenBtg mentioned this pull request Jul 15, 2026

[bug-fix] preset-constitution-not-installed: resolver-aware seeding + post-install reseed #3298

Closed

BenBtg requested a review from Copilot July 15, 2026 15:21

Copilot started reviewing on behalf of BenBtg July 15, 2026 15:22 View session

BenBtg added bug-test and removed bug-fix Trigger the bug-fix agentic workflow labels Jul 15, 2026

Copilot AI reviewed Jul 15, 2026

View reviewed changes

BenBtg previously approved these changes Jul 15, 2026

View reviewed changes

BenBtg changed the title ~~[bug-fix] Fix preset-constitution-not-installed: use PresetResolver in constitution setup~~ test: cover preset constitution seeding through init CLI Jul 15, 2026

BenBtg requested a review from Copilot July 15, 2026 16:20

BenBtg marked this pull request as ready for review July 15, 2026 16:21

Copilot started reviewing on behalf of BenBtg July 15, 2026 16:21 View session

BenBtg self-requested a review July 15, 2026 16:21

BenBtg dismissed their stale review via 84b8f7c July 15, 2026 16:23

Copilot AI reviewed Jul 15, 2026

View reviewed changes

BenBtg requested a review from Copilot July 15, 2026 16:37

Copilot started reviewing on behalf of BenBtg July 15, 2026 16:37 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

BenBtg merged commit f065e27 into main Jul 15, 2026
14 checks passed

mnriem deleted the fix/3272-preset-constitution-not-installed-e6ce3ab03838f7ba branch July 15, 2026 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: cover preset constitution seeding through init CLI#3297

test: cover preset constitution seeding through init CLI#3297
BenBtg merged 5 commits into
mainfrom
fix/3272-preset-constitution-not-installed-e6ce3ab03838f7ba

github-actions Bot commented Jul 1, 2026 •

edited by BenBtg

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenBtg commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

github-actions Bot commented Jul 1, 2026 • edited by BenBtg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenBtg commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 1, 2026 •

edited by BenBtg

Loading