Add custom agent reasoning effort across SDKs#1981
Open
roji wants to merge 5 commits into
Open
Conversation
Expose an optional per-agent reasoning effort across every SDK binding while preserving omission semantics and the reasoningEffort wire name. Add focused serialization, cloning, builder, and DTO coverage plus custom-agent documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32727fc4-2ac8-41eb-a68a-e74674ecf155
Document that omitted per-agent reasoning effort inherits an explicit parent session effort, while omission at both levels leaves the backend to choose. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32727fc4-2ac8-41eb-a68a-e74674ecf155
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional per-agent reasoning effort across all SDKs while preserving wire omission semantics.
Changes:
- Adds language-specific custom-agent reasoning effort APIs.
- Serializes the field as
reasoningEffort. - Adds tests and documentation.
Show a summary per file
| File | Description |
|---|---|
rust/src/types.rs |
Adds Rust field, builder, and tests. |
python/test_client.py |
Tests Python wire conversion. |
python/copilot/session.py |
Adds Python typed configuration. |
python/copilot/client.py |
Converts the field to camel case. |
nodejs/test/client.test.ts |
Tests Node.js request payloads. |
nodejs/src/types.ts |
Adds the TypeScript property. |
java/src/test/java/com/github/copilot/DataObjectCoverageTest.java |
Tests Java DTO behavior. |
java/src/main/java/com/github/copilot/rpc/CustomAgentConfig.java |
Adds Java getter and setter. |
go/types.go |
Adds the Go JSON field. |
go/types_test.go |
Tests Go serialization and omission. |
dotnet/test/Unit/SerializationTests.cs |
Tests .NET serialization. |
dotnet/test/Unit/CloneTests.cs |
Covers cloning the new property. |
dotnet/src/Types.cs |
Adds the .NET property. |
docs/features/custom-agents.md |
Documents model and reasoning overrides. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 2
- Review effort level: Medium
This comment has been minimized.
This comment has been minimized.
Align every binding's CustomAgentConfig description with runtime inheritance semantics for omitted reasoning effort. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32727fc4-2ac8-41eb-a68a-e74674ecf155
This comment has been minimized.
This comment has been minimized.
Capture session.create requests through the public .NET client path instead of reflecting into private serializer options. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32727fc4-2ac8-41eb-a68a-e74674ecf155
This comment has been minimized.
This comment has been minimized.
Document that omitted per-agent reasoning effort sends no override and lets the backend choose its default rather than inheriting the parent session effort. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 32727fc4-2ac8-41eb-a68a-e74674ecf155
Contributor
Cross-SDK Consistency Review ✅This PR adds
All SDKs:
The naming conventions (camelCase for TS/Java, snake_case for Python/Rust, PascalCase for Go/.NET) match each language's established patterns and are consistent with how the existing No consistency issues found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoningEffortwithout adding an SDK defaultThis is SDK-side changes to support https://github.com/github/copilot-agent-runtime/pull/11166 (runtime PR).
Closes github/copilot-sdk-internal#195.
Validation