Skip to content

Add support for diagnostic tags, and use them for mergeDefaultSetupAndUserConfigs#4011

Open
mbg wants to merge 5 commits into
mainfrom
mbg/add-diagnostic-tags
Open

Add support for diagnostic tags, and use them for mergeDefaultSetupAndUserConfigs#4011
mbg wants to merge 5 commits into
mainfrom
mbg/add-diagnostic-tags

Conversation

@mbg

@mbg mbg commented Jul 14, 2026

Copy link
Copy Markdown
Member

Follow-up to #3994 to address @henrymercer's comment there asking us to add the internal-error tag to the new telemetry diagnostics. Since we didn't already support tags on diagnostics in the Action, this PR extends diagnostics.ts with support for them and then uses that for the two new telemetry diagnostics we added in #3994.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from henrymercer July 14, 2026 18:25
@mbg mbg self-assigned this Jul 14, 2026
@mbg mbg requested a review from a team as a code owner July 14, 2026 18:25
Copilot AI review requested due to automatic review settings July 14, 2026 18:25
@github-actions github-actions Bot added the size/S Should be easy to review label Jul 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Adds typed diagnostic tags and marks configuration-merge telemetry as internal errors.

Changes:

  • Adds diagnostic source/tag types.
  • Supports tags in telemetry diagnostics.
  • Applies internal-error to invalid configuration diagnostics.
Show a summary per file
File Description
src/diagnostics.ts Adds tag support and refines diagnostic types.
src/config/db-config.ts Tags merge-validation telemetry diagnostics.
lib/entry-points.js Generated artifact; excluded from review.

Review details

Files excluded by content exclusion policy (1)
  • lib/entry-points.js
  • Files reviewed: 2/3 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread src/config/db-config.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants