feat(bun): Add initWithoutDefaultIntegrations and getDefaultIntegrationsWithoutPerformance#22036
Conversation
…onsWithoutPerformance Brings @sentry/bun to parity with @sentry/node by adding a getDefaultIntegrationsWithoutPerformance() helper and an initWithoutDefaultIntegrations() entry point. init() and getDefaultIntegrations() are refactored to route through them, so existing default behavior is unchanged.
PeterWadie
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Adds initWithoutDefaultIntegrations() and getDefaultIntegrationsWithoutPerformance() to @sentry/bun to align its public SDK surface with @sentry/node, while preserving existing init()/getDefaultIntegrations() behavior via an internal _init helper.
Changes:
- Introduces
getDefaultIntegrationsWithoutPerformance()and refactorsgetDefaultIntegrations()to build on it. - Introduces
initWithoutDefaultIntegrations()and refactorsinit()to delegate through_init(...). - Exports the new functions from the package entry point and adds unit tests covering both.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/bun/src/sdk.ts | Adds new default-integration helper, adds initWithoutDefaultIntegrations, refactors init() through _init. |
| packages/bun/src/index.ts | Exports the new public SDK functions from the Bun package entry point. |
| packages/bun/test/init.test.ts | Adds tests asserting no-default-integration behavior and “without performance” integration set behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export function getDefaultIntegrations(options: Options): Integration[] { | ||
| /** Get the default integrations for the Bun SDK, excluding performance integrations. */ | ||
| export function getDefaultIntegrationsWithoutPerformance(): Integration[] { | ||
| // We return a copy of the defaultIntegrations here to avoid mutating this |
Use nullish coalescing so a nullish defaultIntegrations falls back to the defaults (matching @sentry/node), and clarify the integrations comment.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 95689aa. Configure here.
|
👋 @mydea, @JPeer264, @andreiborza — Please review this PR when you get a chance! |
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Overall LGTM, just one thing I would vote to revert. The rest I'm ok to have for Bun as well
|
|
||
| options.transport = options.transport || makeFetchTransport; | ||
|
|
||
| if (options.defaultIntegrations === undefined) { |
There was a problem hiding this comment.
m: We should leave this as before, even if it looks cleaner and is technically more correct. The reason for that is that we would check against null too with the new implementation, while the older one only matches for undefined. I don't think changing the behavior now is good (especially when other SDKs still have this check)
There was a problem hiding this comment.
Reverted — kept the === undefined check so the null-handling behavior is unchanged (and it stays consistent with @sentry/deno, which uses the same check).
There was a problem hiding this comment.
Did you push it already? It seems that is still the old code
Nvm. I was checking the wrong commit 🤷
Revert the nullish-coalescing change so the null-handling behavior stays as before, consistent with @sentry/deno.
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for your contributions. I'm waiting for one more review before merging. (I'll also see if the CI is happy)
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #22036 Co-authored-by: JPeer264 <10677263+JPeer264@users.noreply.github.com>
Brings
@sentry/bunto parity with@sentry/nodeby adding:getDefaultIntegrationsWithoutPerformance()— the default integration set without the performance/tracing integrations.initWithoutDefaultIntegrations()— initializes the SDK without adding any default integrations, for error-only setups.init()andgetDefaultIntegrations()are refactored to route through these (via an internal_inithelper), so the existing default behavior is unchanged. Both new functions are exported from the package entry point, matching the@sentry/nodesurface.Includes unit tests covering both new functions.
Fixes #14504