Support multi-value returns in TS definitions#27332
Open
stephenduong1004 wants to merge 1 commit into
Open
Conversation
sbc100
reviewed
Jul 13, 2026
sbc100
left a comment
sbc100
left a comment
Collaborator
There was a problem hiding this comment.
Would it be hard to write a test code for this ?
Collaborator
Author
|
@brendandahl do you have any suggestions on writing tests for this? I am not very familiar with upstream tests... |
Collaborator
|
I'd create new test based on a rust test like one of these and also ensure the tsd is emitted correctly (example here) |
Collaborator
Or could we just modify one of the existing tests to add a multi-value return somehow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm-bindgengenerates WebAssembly functions with multiple return values, so we need to remove the assertion that enforces a single return type in tools/emscripten.py. This PR removes the assertion and correctly maps multi-value returns to TypeScript tuples.