skills(running-tend): record settled tend#607 self-review-noop ruling#263
Open
dormouse-bot wants to merge 1 commit into
Open
skills(running-tend): record settled tend#607 self-review-noop ruling#263dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
512e650
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a567e77f.mouseterm.pages.dev |
| Branch Preview URL: | https://skills-settled-self-review-n.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Records a settled upstream ruling in the
running-tendoverlay so futurereview-runs/review-reviewerssweeps don't re-flag it or re-file it upstream.Why
A dormouse
review-runssweep (dormouse#95) surfaced two no-op tend session patterns on bot-authored PRs and, with nedtwigg's approval, filed both upstream. The upstream owner has now ruled on both:tend-reviewself-review no-op) — closed as intended behavior: the diff read is the review (catches lint failures / edge cases even though self-approval is impossible), so a silent exit means the review ran and found nothing to post. Same ruling as tend#212 / mouse-override icon: document in layout spec, switch glyph to CursorTextIcon #154.tend-mentionno-op on undirected bot comments) — fixed upstream (resolved, not rejected).Nightly sweeps recur and a re-filed won't-fix wouldn't surface as a CI failure, so without recording this a future sweep would likely re-derive and re-file the #607 case — wasted session plus upstream spam. This overlay note is the durable guard.
Scope: this only records the outcome; it changes no tend behavior. Surfaced while processing the closure notification for #607.