fix(core): support CJK terms in relaxed FTS fallback#1022
Conversation
|
|
liusiyuxyfx
changed the title
liusiyuxyfx
force-pushed
the
codex/cjk-fts-query-relaxation
branch
from
5ecafe5 to
75da579
Compare
liusiyuxyfx
changed the title
liusiyuxyfx
force-pushed
the
codex/cjk-fts-query-relaxation
branch
from
75da579 to
84ddf63
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84ddf6355a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
liusiyuxyfx
force-pushed
the
codex/cjk-fts-query-relaxation
branch
from
84ddf63 to
529c5e8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 529c5e8f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
liusiyuxyfx
force-pushed
the
codex/cjk-fts-query-relaxation
branch
from
529c5e8 to
ca153d3
Compare
|
@liusiyuxyfx thanks for this PR. Really appreciate the help testing non ascii characters. If it is ready, can you mark it non-draft? |
ready |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca153d3833
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
liusiyuxyfx
force-pushed
the
codex/cjk-fts-query-relaxation
branch
from
36edcdf to
cbfc2e5
Compare
|
@codex review this pr please |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: liusiyuxyfx <779532360@qq.com>
Signed-off-by: liusiyuxyfx <779532360@qq.com>
Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
force-pushed
the
codex/cjk-fts-query-relaxation
branch
from
cbfc2e5 to
27e8012
Compare
|
recheck |
|
@codex review |
phernandez
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27e80123c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review |
|
recheck |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c80bfbf5e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review recheck |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75432ed4db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review recheck |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51bb7d7469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review /recheck |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
Summary
Fix relaxed full-text search fallback for whitespace-separated CJK queries such as
季度 报告while preserving existing ASCII token relaxation behavior.The old eligibility path only extracted ASCII alphanumeric tokens. Short CJK queries split by spaces therefore produced zero tokens, so strict FTS misses never reached the relaxed retry.
What Changed
client-side state managementandfoo/bar baz qux.*versus:*).main, including Postgres savepoint protection.Testing
uv run pytest --no-cov -q tests/services/test_search_service.py tests/repository/test_search_repository.py tests/repository/test_postgres_search_repository.py— 107 passed, 22 skipped.BASIC_MEMORY_TEST_POSTGRES=1 uv run pytest --no-cov -q tests/repository/test_search_repository.py tests/repository/test_postgres_search_repository.py— 57 passed, 12 skipped.just fast-check— passed with the repository's existing Python 3.14 asyncio deprecation diagnostics.git diff --check— passed.