feat: add FileDownloadCrawler#2043
Open
Mantisus wants to merge 2 commits into
Open
Conversation
Mantisus
force-pushed
the
file-downloaw-crawler
branch
from
4669391 to
db4ded0
Compare
Pijukatel
approved these changes
Jul 13, 2026
Pijukatel
left a comment
Pijukatel
left a comment
Collaborator
There was a problem hiding this comment.
For large files, it would be great to have something like https://pypi.org/project/smart-open/ , but our storages lacks interface to support such chunked uploads
vdusek
reviewed
Jul 14, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Otherwise it looks great
vdusek
requested changes
Jul 15, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. However, let's wait with merging for now so we can release one more patch version before we start merging changes for 1.9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FileDownloadCrawlerwith support for streaming the response body in the request handler.Issues
FileDownloadcrawler #875Testing
FileDownloadCrawler