fix: optimize reconnect exception for IoTDB Python Client#18200
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the IoTDB Python client’s session open/reconnect behavior so that reconnect attempts are only triggered for transport/network failures, while IoTDB server status errors (e.g., authentication/account-blocked) fail fast without retrying.
Changes:
- Narrow
Session.open()reconnect-triggering exceptions toIoTDBConnectionException(instead of allException). - Refine
init_connection()exception handling to wrap onlyTTransport.TTransportExceptionasIoTDBConnectionException, while re-raising other exceptions after closing the transport. - Add unit tests to verify “no retry on TSStatus errors (801/822)” and “retry on transport errors”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| iotdb-client/client-py/iotdb/Session.py | Limits reconnect logic to connection-level failures and ensures transport is closed on non-connection exceptions. |
| iotdb-client/client-py/tests/unit/test_session_connection.py | Adds unit coverage validating retry vs. no-retry behavior for transport exceptions vs. IoTDB status errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IoTDB would only try to reconnect only when network exception occured, and
801/822 errorwould not trigger useless reconnection.Content1
Divide
ExceptionintoTTransport.TTransportExceptionandIoTDBConnectionExceptionThis PR has:
for an unfamiliar reader.
for code coverage.