feat: Fuse partition and metrics filtering into manifest deserialization#3658
Open
zenfenan wants to merge 1 commit into
Open
feat: Fuse partition and metrics filtering into manifest deserialization#3658zenfenan wants to merge 1 commit into
zenfenan wants to merge 1 commit into
Conversation
fc4e2f1 to
9492802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3657
Rationale for this change
_open_manifest()currently deserializes all live manifest entries viafetch_manifest_entry()and then applies partitions & metrics filters as a second pass. This materialises the full list before discarding non-matching entries.This PR adds
ManifestFile#prune_manifest_entry()that fuses filtering into the deserialization loop, avoiding the intermediate list allocation for non-matching entries.Are these changes tested?
Yes, existing test suit passes. No behavioral change. Correctness was validated across all benchmark runs (matched entry counts identical between both paths).
Are there any user-facing changes?
No.