[pull] master from monkeytypegame:master#958
Merged
Merged
Conversation
- migrates personal best modal to solidjs, also updates the ux - now all rows show mode2 (dimmed). - also fixes #7998 (adds overflow-y-contain class to AnimatedModal) - renames the `PbTable` to `PbCard` in `UserProfile.tsx` since it is not really a table. --------- Co-authored-by: Christian Fehmer <cfe@sexy-developer.com> Co-authored-by: Jack <jack@monkeytype.com>
Also adds a link.
…onabcd123) (#8091) To reproduce: 1. Switch to `quote` mode 2. Click on the search icon 3. Click on `filter by length` 4. Select `custom` 5. Fill out the min and max values and save 6. Remove it by clicking the `x` next to the word `custom` 7. Repeat steps 3-4 8. Notice how it doesn't open the modal anymore Also removes the notification after saving a custom length filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )