Enable EF database migrations and advanced persistence configuration#5613
Open
johnsimons wants to merge 1 commit into
Open
Enable EF database migrations and advanced persistence configuration#5613johnsimons wants to merge 1 commit into
johnsimons wants to merge 1 commit into
Conversation
Allows ServiceControl to automatically apply EF Core database migrations during the `setup` command. Configures EF Core to use retry-on-failure for transient errors, enhancing database connection stability. Adds an option to enable sensitive data logging for debugging purposes. Switches from `AddPooledDbContextFactory` to `AddDbContext` for direct `DbContext` access and improved flexibility.
rbev
approved these changes
Jul 16, 2026
| { | ||
| public async Task ApplyMigrations(CancellationToken cancellationToken = default) | ||
| { | ||
| logger.LogInformation("Starting SQL Server database migration"); |
Contributor
There was a problem hiding this comment.
Apart from the log messages these are identical - could they go in the shared code?
Don't the manifest settings end up in the container so you could format the log strings out of that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows ServiceControl to automatically apply EF Core database migrations during the
setupcommand.Configures EF Core to use retry-on-failure for transient errors, enhancing database connection stability.
Adds an option to enable sensitive data logging for debugging purposes.
Switches from
AddPooledDbContextFactorytoAddDbContextfor directDbContextaccess and improved flexibility.