docs(mobile): document that PHP source ships readable in the app package#428
Open
shanerbaner82 wants to merge 1 commit into
Open
docs(mobile): document that PHP source ships readable in the app package#428shanerbaner82 wants to merge 1 commit into
shanerbaner82 wants to merge 1 commit into
Conversation
Add 'Your code ships with your app' section to the v3/v4 security pages explaining the security model (bundled source is readable, encryption would be theater, keep secrets server-side, use cleanup_env_keys), and clarify on the v3/v4 configuration pages that the R8/ProGuard build options only affect Kotlin/Java, not the bundled PHP. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by a user report that PHP source files are visible after extracting a production APK (built with mobile v3.3.6) with APKTool/jadx, and asking whether the built-in obfuscation options help.
That's expected behavior — the app bundle ships as a plain asset and the R8/ProGuard options only touch Kotlin/Java — but neither fact was documented, and the configuration page's
obfuscateoption could easily be read as covering app code.Security pages (v3
concepts/security.md, v4digging-deeper/security.md): new "Your code ships with your app" section explaining:cleanup_env_keysConfiguration pages (v3 + v4
getting-started/configuration.md): theobfuscatebullet now says "Kotlin/Java class and method names", plus a paragraph after the Android Build Configuration section stating these options don't affect the bundled PHP, linking to the new security section.🤖 Generated with Claude Code