You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@benhg, @leofang: I checked CUDA 12.0–13.3 and NVSHMEM cu12 wheels 3.6.5, 3.7.0, and 3.7.1. All actual bitcode filenames end in .bc, but NVSHMEM’s bitcode directory also contains .a archives, the host .so, and bootstrap/transport plugins. As written, find/locate_bitcode_lib_by_name() can return any of those by basename. Should the API require a .bc filename, or is generic exact-name lookup within the configured directory intentional? Would suffix validation be the right contract, or do we want content-level bitcode validation?
@benhg, @leofang: I checked CUDA 12.0–13.3 and NVSHMEM cu12 wheels 3.6.5, 3.7.0, and 3.7.1. All actual bitcode filenames end in .bc, but NVSHMEM’s bitcode directory also contains .a archives, the host .so, and bootstrap/transport plugins. As written, find/locate_bitcode_lib_by_name() can return any of those by basename. Should the API require a .bc filename, or is generic exact-name lookup within the configured directory intentional? Would suffix validation be the right contract, or do we want content-level bitcode validation?
I could go either way. The argument in favor of looser checking is we may have new formats (e.g. .bc.fatbin or .bc.gz or something), and could use the same function to support .ltoir. The argument against is more risk of bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda.pathfinderEverything related to the cuda.pathfinder modulefeatureNew feature or requestP0High priority - Must do!
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses new design of #2200.