Correctly set alarms during blocking processing#209
Open
AlexanderWells-diamond wants to merge 3 commits into
Open
Correctly set alarms during blocking processing#209AlexanderWells-diamond wants to merge 3 commits into
AlexanderWells-diamond wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 88.39% 88.41% +0.01%
==========================================
Files 15 15
Lines 1258 1260 +2
==========================================
+ Hits 1112 1114 +2
Misses 146 146 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was an oversight in PR #202
AlexanderWells-diamond
force-pushed
the
blocking_alarm_fixes
branch
from
ab35384 to
d871362
Compare
AlexanderWells-diamond
force-pushed
the
blocking_alarm_fixes
branch
2 times, most recently
from
81b75a7 to
509ce53
Compare
I can't see a reason why we should only set these values if they are non-zero, it's perfectly valid to do this to reset errors
AlexanderWells-diamond
force-pushed
the
blocking_alarm_fixes
branch
from
509ce53 to
6b991a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an oversight in PR #202