Skip to content

Fix slot number determination logic for the FIB workflow#842

Open
tieneupin wants to merge 2 commits into
mainfrom
slot-number-fix
Open

Fix slot number determination logic for the FIB workflow#842
tieneupin wants to merge 2 commits into
mainfrom
slot-number-fix

Conversation

@tieneupin

@tieneupin tieneupin commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

In the Aquilos, the stage rotation value will be set to -75 degrees during normal milling and when acquiring SEM images. The xy coordinates at this rotation value are used to identify the slot number.

The xy coordinates needed to keep the same region in view will change as the stage is rotated, so a transformation matrix will need to be applied using the xy coordinates and the current rotation value to determine what the xy coordinates of the viewed region will be at the standard viewing/milling angle, and thus what slot number it belongs to.

This PR adds the coordinate transformation logic needed to determine the slot number to the StagePosittionValues Pydantic model, and updates the relevant tests accordingly.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.48%. Comparing base (c85221f) to head (f52b8e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   53.47%   53.48%   +0.01%     
==========================================
  Files         103      103              
  Lines       11071    11075       +4     
  Branches     1476     1476              
==========================================
+ Hits         5920     5924       +4     
  Misses       4831     4831              
  Partials      320      320              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review July 16, 2026 10:44
@tieneupin tieneupin self-assigned this Jul 16, 2026
@tieneupin tieneupin added bug Something isn't working server Relates to the server component fib Part of the FIB pipeline extension labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant