Skip to content

Manchester | 26-ITP-May |Samreen Amjad| Sprint 1 | Coursework#1503

Open
serveyano wants to merge 1 commit into
CodeYourFuture:mainfrom
serveyano:coursework/sprint-1
Open

Manchester | 26-ITP-May |Samreen Amjad| Sprint 1 | Coursework#1503
serveyano wants to merge 1 commit into
CodeYourFuture:mainfrom
serveyano:coursework/sprint-1

Conversation

@serveyano

@serveyano serveyano commented Jul 12, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

[x] have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[x] My changes meet the requirements of the task
[x] I have tested my changes
[x] My changes follow the style guide

Changelist

This PR is for coursework sprint 1

@serveyano serveyano added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 12, 2026
@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 15, 2026

// c) Identify all the lines that are variable reassignment statements

//Lines 7 & 8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take another look at your answer for part c? Check whether the lines you've identified are actually reassigning a variable, or if they're doing something else.


// d) Identify all the lines that are variable declarations

//Lines 1 & 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you review your answer for part d as well? It may help to revisit the difference between a variable declaration and other operations involving variables.

@hey-hammad

Copy link
Copy Markdown

Hi @serveyano

Nice work overall. I have a few suggestions that will help you build good habits as you continue through the course:

Commit history
I noticed there is a single commit in this PR. No changes are needed for this exercise, but it's worth knowing that a clean commit history becomes very useful on larger projects. It helps others understand your thought process, track progress, and review changes more easily. This is something to keep in mind for future PRs.

Line endings
GitHub is showing a line-ending change in multiple files(red-circle). While it's a minor issue, consistent line endings help avoid unnecessary changes appearing in PRs and make collaboration smoother across different operating systems.

Fix for VSCode: https://stackoverflow.com/a/44704969

Keep up the good work!

@hey-hammad hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants