Skip to content

London | ITP 26 May | Sayeed Hussain | Sprint 2 | CourseWork#1494

Open
sayeedhussain01 wants to merge 13 commits into
CodeYourFuture:mainfrom
sayeedhussain01:acoursework/sprint-2
Open

London | ITP 26 May | Sayeed Hussain | Sprint 2 | CourseWork#1494
sayeedhussain01 wants to merge 13 commits into
CodeYourFuture:mainfrom
sayeedhussain01:acoursework/sprint-2

Conversation

@sayeedhussain01

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed all task.

@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 10, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 10, 2026
@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 changed the title London | ITP 26 May | Sayeed Hussain | Sprint 2 | Coursework/sprint 2 London | ITP 26 May | Sayeed Hussain | Sprint 2 | CourseWork Jul 10, 2026
@github-actions

This comment has been minimized.

@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 10, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 10, 2026
@sayeedhussain01 sayeedhussain01 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 11, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on these tasks, I have a couple of questions to check your understanding.

function calculateBMI(weight, height) {
// return the BMI of someone based off their weight and height
} No newline at end of file
let allHeight = Number(height * height);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you using Number() to do here?

currentOutput2 === targetOutput2,
`current output: ${currentOutput2}, target output: ${targetOutput2}`
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do your test cases properly test every part of your function? Do they ensure that minutes are tested?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants