London | 26-ITP-May | Chun Yan Wong | Sprint 3 | practice-TDD#1492
Open
cywong-dev wants to merge 7 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 3 | practice-TDD#1492cywong-dev wants to merge 7 commits into
cywong-dev wants to merge 7 commits into
Conversation
Implement logic to return ordinal numbers based on input.
Added tests for ordinal number handling for 2nd, 3rd, th exceptions, and general cases.
Implement repeatStr function to repeat a string a given number of times without using String.prototype.repeat. Handle negative count by throwing an error.
Added test cases for repeatStr function to handle edge cases including count of 1, 0, and negative values.
This comment has been minimized.
This comment has been minimized.
cywong-dev
changed the title
This comment has been minimized.
This comment has been minimized.
cywong-dev
added
Needs Review
LonMcGregor
reviewed
Jul 15, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start. Part of TTD is running tests as you write code. Have you been doing that? I got some errors when I ran the tests.
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| let char = ""; |
There was a problem hiding this comment.
What does defining the char variable outside of the for loop do here?
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
|
|
||
| for (let i = 0; i < count; i++) { |
There was a problem hiding this comment.
Have you tried running the test here. When I run it, I get an error
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X] My changes follow the style guide
Changelist
Create the JEST test cases for the coursework