Skip to content

Update release version in package.json#1029

Merged
cx-alon-rosenhek merged 5 commits into
mainfrom
other/refactor_gh_workflow
Jul 10, 2026
Merged

Update release version in package.json#1029
cx-alon-rosenhek merged 5 commits into
mainfrom
other/refactor_gh_workflow

Conversation

@cx-atish-jadhav

Copy link
Copy Markdown
Contributor

No description provided.

@cx-anurag-dalke cx-anurag-dalke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

…onflicts

- Removed registry-url parameter from setup-node action in ci.yml and release.yml
- Registry configuration now handled exclusively by .npmrc file
- Auth tokens configured via npm config commands with ECHO_LIBRARIES_ACCESS_KEY
- Eliminates NODE_AUTH_TOKEN environment variable creation and logging
- Fixes 403 Forbidden errors during npm ci with Echo registry
- Maintains dual-registry support: Echo for dependencies, GitHub for publishing

Changes:
- .github/workflows/ci.yml: Removed registry-url from setup-node
- .github/workflows/release.yml: Removed registry-url from setup-node

This ensures proper authentication with Echo (npm.echohq.com) registry while avoiding conflicts with GitHub Actions' automatic NODE_AUTH_TOKEN creation.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cx-atish-jadhav and others added 3 commits July 10, 2026 14:07
…stry-url

Root cause was npm config precedence: the project-level .npmrc (checked
into the repo) always overrides user-level config, so its literal blank
auth token lines were shadowing whatever the separate "npm config set"
step wrote at the user level - regardless of registry-url on setup-node.

- .npmrc now resolves tokens via ${ECHO_LIBRARIES_ACCESS_KEY} at read
  time instead of committing blank placeholders, so the project-level
  config itself carries valid auth.
- Restored registry-url on setup-node in ci.yml/release.yml (safe now
  that .npmrc's interpolated values take precedence over it either way).
- Removed the now-redundant "Configure echohq auth" npm config set steps.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… logs

Diagnostic-only change to show explicit HTTP fetch URLs in CI output.
Will be reverted once confirmed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@cx-anurag-dalke cx-anurag-dalke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@cx-anurag-dalke cx-anurag-dalke enabled auto-merge (squash) July 10, 2026 09:27
@cx-alon-rosenhek cx-alon-rosenhek merged commit 0877c5c into main Jul 10, 2026
2 of 4 checks passed
@cx-alon-rosenhek cx-alon-rosenhek deleted the other/refactor_gh_workflow branch July 10, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants